Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 0.1.16 + Rust FFI Logger init causes test to fail #230

Closed
YOU54F opened this issue Nov 14, 2022 · 2 comments
Closed

Protobuf 0.1.16 + Rust FFI Logger init causes test to fail #230

YOU54F opened this issue Nov 14, 2022 · 2 comments

Comments

@YOU54F
Copy link
Member

YOU54F commented Nov 14, 2022

Noticed some odd behaviour.

Using Protobuf 0.1.16 + and invoking the Rust FFI Logger causes test to fail, as the plugin cannot start up.

gRPC tests appear to be failing whenever I invoke something like

      PactRubyFfi.pactffi_logger_init
      PactRubyFfi.pactffi_logger_attach_sink('stderr', PactRubyFfi::FfiLogLevelFilter['LOG_LEVEL_DEBUG'])
      PactRubyFfi.pactffi_logger_apply
      PactRubyFfi.pactffi_log_message('pact_ruby', 'INFO', 'pact ruby grpc is alive') 

only noticed the failure today, as my CI run, is installing the latest proto plugin, and only got a passing test again, when I set the log level filter to 0. The current value is mapping through as 4 to the underlying ffi

edit: sidenote wasn't sure on the best repo, pact_plugins, pact proto or this one, so just popped it here for now

@rholshausen
Copy link
Contributor

Looks like it is getting IO errors trying to connect to the plugin. I don't think this is related to logging, as I can see some logs from the plugin, or maybe, the amount of logging is exhausting some buffer and causing the IO errors.

The plugin creates a log file in the plugin directory, it might be worth while attaching those files as build artifacts so we can see if there is any error from the plugin side

@YOU54F
Copy link
Member Author

YOU54F commented Dec 6, 2022

Will close this for now and re-raise if I see the issue crops up again in a new release

@YOU54F YOU54F closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants