Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby pact-provider-verifier --enable-pending returns non-zero exit code if pending pact provider state setup fails #251

Open
StefanSmithGousto opened this issue Nov 19, 2021 · 2 comments · May be fixed by pact-foundation/pact-provider-verifier#84

Comments

@StefanSmithGousto
Copy link

StefanSmithGousto commented Nov 19, 2021

Observed behaviour

The Ruby pact-provider-verifier tool (with --enable-pending on) returns a non-zero exit code if POST to Provider States Setup URL responds with a 500 status when verifying a pending pact.

Expected behaviour

The --enable-pending flag should suppress both verification and provider state setup failures for pending pacts. It only seems to suppress the former. This means a consumer can break a provider's mainline build if they define an unsupported provider state.

Work arounds

One solution would be for the provider to gracefully handle unsupported provider state but we'd rather see these failures published to our Pact Broker so the consumer is aware of the root cause of verification failure. That is the current behaviour (great!) but we'd like this to happen without blocking the Provider's pipeline.

@bethesque
Copy link
Member

Thanks Stefan. I'll look into this for you.

@bethesque
Copy link
Member

Sorry Stefan, this dropped off my radar. I'll try and get on to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants