-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: CI/CD update - branches / contract_requiring_verification_published webhook #149
Conversation
website/docs/docs/workshops/ci-cd.md
Outdated
@@ -1,6 +1,6 @@ | |||
--- | |||
id: ci-cd | |||
title: Pactflow CI/CD Workshop | |||
title: Consumer-Driven Contract Testing Workshop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call to clarify this now we have two different workflows. Can we make it "Consumer-Driven Contract Testing CI/CD Workshop"? Or "Consumer-Driven Contract Testing Workflow Workshop" (that one is a bit of a W mouth-full though). The point of this one is to show users how CDC fits into the pipeline, not just how to do consumer driven contract testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gone for
Consumer-Driven Contract Testing CI/CD Workshop
Consumer-Driven Contract Testing CI/CD Workshop (Legacy)
website/docs/docs/workshops/ci-cd/set-up-ci/04_configure_webhook.md
Outdated
Show resolved
Hide resolved
Hoorah for this update happening! |
website/docs/docs/workshops/ci-cd-legacy/set-up-ci/04_configure_webhook.md
Outdated
Show resolved
Hide resolved
Hey @Ilia I've addressed these
Not done this one yet, but it's not a bad shout, having it as a secret means the user can just add it during the pb token step 👍🏾
|
Sometimes duplicated+simple is better than shared+moreComplicated ;) |
* the latest version from the provider's main branch | ||
* any version currently deployed to an environment | ||
|
||
This is achieved by passing the URL of the changed pact to the build via a parameter in the body of the webhook request, as well as the provider version number and the provider branch of the head, test and production versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
head -> main
* Consumer: leave as "ALL" | ||
* Provider: select `pactflow-example-provider` | ||
* Events: select `Contract published with changed content or tags` | ||
* Events: select `Contract published that requires verification` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woot!
Before starting the consumer, create a `.env` file in the root of the project and add: | ||
Before starting the consumer, we need to configure it so it knows the address of our running provider. | ||
|
||
create a `.env` file in the root of the project and add: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create
|
||
A "work in progress" pact is a pact that is the latest for its tag that does not have any successful verification results (ie. is still pending) for the configured provider tag . At this stage in the exercise, the `feat/new-field` pact is still in pending state for the `master` branch of the provider, so it is considered a "work in progress" pact for master. | ||
A "work in progress" pact is a pact that is the latest for its branch that does not have any successful verification results (ie. is still pending) for the configured provider branch . At this stage in the exercise, the `feat/new-field` pact is still in pending state for the main branch of the provider, so it is considered a "work in progress" pact for `master`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's slightly more complicated than this now. My brain is not working so I'll come back to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I think about it, it's not worth confusing people with the full technical details of how WIP pacts are selected at this stage. What you've got is 👍🏽
This makes me so happy!!!! 🎉 |
✅ Deploy Preview for docs-pactflow-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Will merge it and go through with the SE team next week for some user feedback :) |
Update Pactflow CI/CD Workshop