eachValue matcher not working as expected

[rholshausen]

Original issue: pact-foundation/pact-plugins#22

eachValue matcher for checking list of items not working as expected.

"item": ['somevalue1', 'somevalue2']
"item": "eachValue(matching(type, '00000000000000000000000000000000'))"

Getting below error from pact-plugin:

pact_protobuf_plugin::mock_service: Failed to match the request message - BodyMismatches({"$.item": [BodyMismatch { path: "$.item[0]", expected: Some(b""), actual: Some(b"00000000000000000000000000000000"), mismatch: "Unable to match '' using EachValue(MatchingRuleDefinition { value: \"00000000000000000000000000000000\", value_type: Unknown, rules: [Left(Type)], generator: None })" }]})

[github-actions]

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-1017). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

[rholshausen]

0.3.2 released with this fix

[jasonltaylor]

@rholshausen It looks like there may still be an issue with nesting? Or could be user error on my part. Once I add the eachValue to the permissions field below (where permissions is just a repeated string):

		"response": {
			"resource_permissions": {
				"pact:match": "eachValue(matching($'ResourceUserPermission'))",
				"ResourceUserPermission": {
					"resource": {
						"application_resource": "matching(type, 'foo')",
						"permissions": "eachValue(matching(type, 'foo'))",
						"groups": ["bar"]
					},
					"effect": {
						"result": "ENFORCE_EFFECT_ALLOW"
					}
				}
			}
		}

I run into an error:

2023-06-14T16:14:46.396606Z ERROR ThreadId(01) pact_ffi::plugins: Failed to call out to plugin - "*" is not allowed in an identifier in path expression "$.resource_permissions*.resource.permissions" at index 22

[mefellows]

That's an interesting syntax. Ron is there something in Pact Go I need to support differently to allow this scenario?

[rholshausen]

No, that should be all handled in the plugin

[rholshausen]

This bit is wrong resource_permissions*, it is not setting the matching rule correctly.

[rholshausen]

Ok, try 0.3.3.

[jasonltaylor]

@rholshausen With 0.3.3, still seeing an issue with regex:

"groups": "eachValue(matching(regex, '[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}|\\*', '00000000000000000000000000000000'))"

Looks like it may be adding double quotes to the string?

$.resource_permissions[9].resource.groups -> Expected '3:(groups, LengthDelimited, String) = "*"' to match '[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}|\*'

If I intentionally mismatch without a eachValue I don't see the double quotes in the error:

$.resource_permissions[9].resource.groups[0] -> Expected '*' to match '[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}'

[jasonltaylor]

Actually, I guess it looks more like it is just pulling in some metadata/not parsing out the value properly?

[rholshausen]

Ah, that is a bug with the Pact libs: pact-foundation/pact-reference#283. It will need the Pact libs to be released and then we can update the plugin.

[rholshausen]

3rd time the charm? Try 0.3.4

[jasonltaylor]

Is working with 0.3.4 - tx!