Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating protocVersion in plugin config doesn't take effect #41

Closed
rkrishnan2012 opened this issue Jan 19, 2024 · 0 comments · Fixed by #42
Closed

Updating protocVersion in plugin config doesn't take effect #41

rkrishnan2012 opened this issue Jan 19, 2024 · 0 comments · Fixed by #42

Comments

@rkrishnan2012
Copy link
Contributor

When passing the protocVersion in the plugin config similar to additionalIncludes, the plugin doesn't adhere to the value passed in. It instead uses the value that's in the manifest.

This is necessary for folks to support M1 macs without needing to update the plugin version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix merging between plugin config and manifest values. rkrishnan2012/pact-protobuf-plugin
1 participant
@rkrishnan2012