Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: musl variants #47

Closed
wants to merge 3 commits into from
Closed

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Feb 9, 2024

Create musl based variants of

  • pact-protobuf-plugin

Tracking issue:- pact-foundation/devrel#30

Follows on from pact-foundation/pact-reference#372

Will also require updates in pact-plugin-cli to

  1. provide support to check for and download musl variants
  2. provide musl variants of the exe

Additionally

  • pins cross to 0.2.5 to ensure we build against the correct version of glib, issue from pact-ref

@YOU54F
Copy link
Member Author

YOU54F commented Mar 4, 2024

I've tested this against various forks of our pact projects (pact-php, pact-js-core/pact-js) and my hello_ffi project and it is working well under alpine.

Failures are due to not having relevant access to tokens to publish pacts

Sample builds are available on my fork release

https://github.com/YOU54F/pact-protobuf-plugin/releases/tag/v-0.3.13

@YOU54F YOU54F requested a review from rholshausen March 4, 2024 23:13
@rholshausen
Copy link
Contributor

I think for executables we should only publish musl variants. It does not make sense to have a glibc version and a musl version. The musl version will run on glibc distributions. In fact, this was the reason musl was created.

@YOU54F
Copy link
Member Author

YOU54F commented Mar 16, 2024

That makes total sense Ron, I should have actually tested that out xD

this PR will be re-approached to consider building only a musl variant for linux, and providing it with the name of the existing glibc based executable.

The resulting binary should work for all, and simplifies any musl or os detection requirements for linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants