Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging allOf references before validation #14

Closed
YOU54F opened this issue Oct 28, 2022 · 3 comments
Closed

Merging allOf references before validation #14

YOU54F opened this issue Oct 28, 2022 · 3 comments
Labels
smartbear-supported Issues with this label have been added to the Pactflow team's Jira backlog

Comments

@YOU54F
Copy link
Member

YOU54F commented Oct 28, 2022

allOfs cause pain in validation.

You can pre-process them

https://github.com/YOU54F/oas-merge

Wonder if we should just add this as part of the tool

@mefellows mefellows added the smartbear-supported Issues with this label have been added to the Pactflow team's Jira backlog label May 24, 2023
@github-actions
Copy link
Contributor

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-1037). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

@mefellows
Copy link
Contributor

Closing this off, the following PRs have addressed it via a much nicer and less invasive means:

@mefellows
Copy link
Contributor

The detailed explanation for all of keyword support now lives here: https://docs.pactflow.io/docs/bi-directional-contract-testing/contracts/oas/keyword-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartbear-supported Issues with this label have been added to the Pactflow team's Jira backlog
Projects
None yet
Development

No branches or pull requests

2 participants