Feat: Upgrade AJV from 6 to 8 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vwong
commented
Jun 27, 2023
| @@ -0,0 +1,20 @@ | |||
| diff --git a/node_modules/ajv/dist/compile/validate/dataType.js b/node_modules/ajv/dist/compile/validate/dataType.js | |||
There was a problem hiding this comment.
While waiting for ajv-validator/ajv#2297, we patch this locally
| @@ -145,35 +145,6 @@ describe('openapi3/parser', () => { | |||
| }]); | |||
| }); | |||
|
|
|||
| it('should support the nullable schema keyword in an object property without type', async () => { | |||
There was a problem hiding this comment.
Comment on lines
+63
to
+64
| exclusiveMaximum?: number; | ||
| exclusiveMinimum?: number; |
There was a problem hiding this comment.
OpenAPI defines these as booleans, as did AJV@6.
But since https://json-schema.org/draft-06/json-schema-release-notes.html, it has been converted to a number. AJV followed suite.
Comment on lines
-359
to
-361
| const minimumInt64AllowedMinusOne = '-9223372036854775809'; | ||
| const maximumInt64Allowed = '9223372036854775807'; | ||
| const maximumInt64AllowedPlusOne = '9223372036854775808'; |
There was a problem hiding this comment.
See ajv-validator/ajv-formats#22 (comment)
TLDR: JSON only supports doubles, and JS (without resorting to BigInt) too; pretending otherwise is pointless.
Inksprout
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullablerequires use oftype, see https://github.com/ajv-validator/ajv/blob/490eb8c0eba8392d071fef005e16d330f259d0ba/lib/compile/validate/dataType.ts#L26C66-L26C66