Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing CapnP with gRPC for http package #418

Closed
b00f opened this issue Oct 23, 2022 · 2 comments · Fixed by #427
Closed

Replacing CapnP with gRPC for http package #418

b00f opened this issue Oct 23, 2022 · 2 comments · Fixed by #427
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@b00f
Copy link
Collaborator

b00f commented Oct 23, 2022

CapnP package is deprecated and should be removed. We need to replace CapnP with gRPC in http package:

pactus/www/http/server.go

Line 24 in 58c9045

capnp capnp.PactusServer

@b00f b00f added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 23, 2022
@ghost
Copy link

ghost commented Nov 12, 2022

Is help still wanted for this?

@b00f
Copy link
Collaborator Author

b00f commented Nov 14, 2022 •
edited
Loading

@braewoods Yes, Please! We even have a Bounty for this issue. Check here

Please join our Discord server. https://discord.gg/H5vZkNnXCu
The development team are there and they can provide you more information.

This was referenced Nov 15, 2022
Merged
Merged
@b00f b00f closed this as completed in #427 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert HTTP module to use GRPC module instead of CAPNP module
1 participant
@b00f