Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin specific command #25

Open
pbogut opened this issue Feb 24, 2016 · 3 comments
Open

Plugin specific command #25

pbogut opened this issue Feb 24, 2016 · 3 comments

Comments

@pbogut
Copy link
Member

pbogut commented Feb 24, 2016

I would like to be able to add a custom command to padawan.php plugin. As far as I can tell this is currently not possible.
Can we add something like special route, where we can pass plugin action?
I was thinking about a command that will dispatch event, which can be handled by the plugin.
What do you think? I'm happy to write a patch if you think that's a good idea.

@pbogut pbogut changed the title Plugin specific commands to plugins Plugin specific command Feb 24, 2016
@mkusher
Copy link
Member

mkusher commented Feb 25, 2016

@pbogut yeah, it can be a good idea, but first of all, why do you need it?

@pbogut
Copy link
Member Author

pbogut commented Feb 25, 2016

Ok, so I'm going back to my Magento plugin. Magento is using XML for many things including defining classes generated by a factory method. When XML file is changing it should be reloaded by the plugin. With custom plugin command it should be easy enough to trigger this action (manually, or by an auto command in vim on a buffer save).
Hopefully, that makes sense.

@mkusher
Copy link
Member

mkusher commented Feb 25, 2016

The problem I see right now is structure and API of padawan, that's going to change soon(hope in March I'll have enough time). So, I'm afraid your plugin/change will be incompatible with the next padawan version. Of course, if you do it, I'll try to help in migration and so.
Saying honestly I'm not even sure whether I'll break this thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants