Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace completion issue #66

Open
pbogut opened this issue Sep 16, 2016 · 1 comment
Open

Namespace completion issue #66

pbogut opened this issue Sep 16, 2016 · 1 comment

Comments

@pbogut
Copy link
Member

pbogut commented Sep 16, 2016

When I have class with namespace like this:

<?php

namespace My\Name\Space;

class MyClass {
  public function testFunction() {
    new DateTi //case 1
    new \DateTi //case 2
  }
}

For case one padawan is giving suggestions when pointing on 9th column (D letter), but for the case 2 when pointing at 10th column (D letter as in case 1).
Is that how it should be?
I'm not even sure if the case 1 should be suggested as the code is invalid (it's creating My\Name\Space\DateTi.... For the second case, shouldn't completion work when pointing at backslash (as it is part of the class name)?

@mkusher
Copy link
Member

mkusher commented Sep 17, 2016

that's because padawan uses same completer for use completion and classes completion after new and extends. So we need new completer that will check uses and will create relative name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants