This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
admin view fix #40
Merged
admin view fix #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,8 +117,9 @@ private InputToModelParseResult validate(Map<String, Object> inputMap){ | |||
| for(Map.Entry<String, Object> entry : inputMap.entrySet()){ | |||
| if(entry.getKey().equals("firstname")) continue; | |||
| if(entry.getKey().equals("position")) continue; | |||
| if(entry.getKey().equals("permission")&& entry.getValue() instanceof Permission) continue; | |||
There was a problem hiding this comment.
Why do you not validate the permission value?
There was a problem hiding this comment.
Isn't it validated with StringValidator? because if its empty, its added to failed inputs, as shown in the tests.
There was a problem hiding this comment.
Ah yes, sorry misread it. Except now you cannot edit a user because it doesn't see permission as valid
|
I also get an error trying to update a user: "permission required" |
| @@ -60,7 +60,13 @@ private Staff parseUser(Map<String, Object> inputMap){ | |||
| String lastname = (String) inputMap.get("lastname"); | |||
| String department = (String) inputMap.get("department"); | |||
| String position = (String) inputMap.get("position"); | |||
| Permission permission = (Permission) inputMap.get("permission"); | |||
| Permission permission; | |||
| try{ | |||
There was a problem hiding this comment.
This line should be indented one less step
|
Merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.