Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deepcopy of PythonOCC #1

Open
paddy-r opened this issue Dec 9, 2022 · 2 comments · Fixed by #15
Open

Enable deepcopy of PythonOCC #1

paddy-r opened this issue Dec 9, 2022 · 2 comments · Fixed by #15
Assignees

Comments

@paddy-r
Copy link
Owner

paddy-r commented Dec 9, 2022

Need to modify three scripts in PythonOCC to allow deepcopy of them: Quantity_Color, TDF_Label and TopLoc_Location.

Mentioned in this issue at PythonOCC, but never addressed: tpaviot/pythonocc-core#1097

@paddy-r paddy-r self-assigned this Dec 9, 2022
@paddy-r
Copy link
Owner Author

paddy-r commented Jan 21, 2023

Currently done manually by copy and paste, which is not elegant. Need to:

  • Write script to automatically check classes in PythonOCC and modify if necessary
  • Incorporate this into environment setup/installation No, keep separate.

Refer to Vivarium fix script in #109 commits. Not relevant, monkey-patch instead of modifying library.

@paddy-r paddy-r linked a pull request Feb 1, 2023 that will close this issue
@paddy-r
Copy link
Owner Author

paddy-r commented Feb 1, 2023

Reopen to allow fix to repr issue related to deepcopy; closed #16 to avoid duplication.

Update 15/03/23, getting TypeError: cannot pickle 'SwigPyObject' object when trying to duplicate assemblies, suggesting issue still present...

Leaving this issue as is (as want to fix by runtime patch eventually) and podding off into another to fix by manually hacking library, as before (not the best solution!) -> #22.

@paddy-r paddy-r reopened this Feb 1, 2023
@paddy-r paddy-r changed the title Automatically modify PythonOCC files to allow deepcopy Enable deepcopy of PythonOCC Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant