Fixes #311 PHP fatal error #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se PHP to error out when called in a destructor.
|
Changes Unknown when pulling b36a868 on realityking:master into * on padraic:master*. |
davedevelopment
added a commit
that referenced
this pull request
Apr 9, 2014
Fixes #311 PHP fatal error
|
@realityking I'll try and get a 0.9.1 release out tomorrow, but I'm a bit pushed for time. |
|
Thank you. It's not that urgent, but sometime this month would be awesome. |
|
Any news about a 0.9.1? The SwiftMailer pull request has since been merged, so currently it requires a dev version which isn't too nice. |
|
@realityking Sorry, see #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: #311
Due to a memory handling issue in PHP core Mocks might cause PHP to error out when called in a destructor.
The workaround works because it causes ReflectionClass to create a new class entry and not reuse the one from the existing object. Alternatively
ReflectionClasscould be replaced withReflectionObject.Relevant part of the code: http://lxr.php.net/xref/PHP_5_5/ext/reflection/php_reflection.c#3313
Any chance to get this in a tagged release quickly? It kinda gets in the way of my SwiftMailer work ;)