-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually build up argument list #504
Manually build up argument list #504
Conversation
$sample[$key] = self::formatArgument($value, $depth + 1); | ||
$key = is_int($key) ? $key : "'$key'"; | ||
$value = self::formatArgument($value, $depth + 1); | ||
$sample[]= "$key => $value"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta G
This needs rebasing to load in the previous fixes to get stuff passing. |
@@ -1270,6 +1270,22 @@ public function testHandlesMethodWithArgumentExpectationWhenCalledWithNestedReso | |||
} | |||
|
|||
/** | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty phpdoc?
8f1a234
to
e348bd8
Compare
Test case: <?php
require "vendor/autoload.php";
$mock = Mockery::mock();
$mock->shouldReceive('push')->with('value', ['var2' => 'true']);
$mock->push('value', ['var2' => true, 'var 123' => 'with spaces']); Master:
This PR
👍 from me! Thanks for putting your time and effort into this. |
Manually build up argument list
Fixes #503