Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular style helper #1673

Closed
namusyaka opened this issue May 3, 2014 · 4 comments
Closed

Modular style helper #1673

namusyaka opened this issue May 3, 2014 · 4 comments
Assignees
Milestone

Comments

@namusyaka
Copy link
Contributor

I want to change the helpers to modular style for testability.
For example, helper.rb.tt will be something like this.

module <%= @project_name %>
  class <%= @app_name %>
    module <%= @helper_name %>
      # def simple_helper_method
      # ...
      # end
    end

    helpers <%= @helper_name %>
  end
end

@padrino/core-members What do you think?
If OK, I'm going to get to work on this.

@dariocravero
Copy link

👍 @namusyaka, sounds good to me. It might also hint people better that they can redistribute these too.

@namusyaka namusyaka self-assigned this May 5, 2014
@nesquena
Copy link
Member

nesquena commented May 5, 2014

Seems reasonable to me as well.

@namusyaka
Copy link
Contributor Author

@dariocravero @nesquena Thank you for the opinions!
I've changed the format of helper, and the generator came to create a helper test file.
Please confirm it!

@nesquena nesquena added this to the 0.12.2 milestone May 7, 2014
@ujifgc
Copy link
Member

ujifgc commented May 8, 2014

Closed via 21c4c2d

@ujifgc ujifgc closed this as completed May 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants