ApplicationWrapper Prerequisite Issue #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Reloader and other classes assume that any mounted Padrino app has "prerequisites" (plural!) set, and uses that to figure out what files need to be reloaded. And, in the documentation, it says to ```MyApp.prerequisites << "somefile.rb"``` if you want to configure your application to reload/require new things. This doesn't seem to break an actual Padrino app, as all the internal Padrino code (besides this) uses the plural. However, when I mount (and therefore wrap) my Grape::API application, reloading breaks, because there is no list of pluralized prerequisites to work with. Boo!
|
My bad. Sorry and thank you so much! |
namusyaka
added a commit
that referenced
this pull request
Jan 5, 2015
ApplicationWrapper Prerequisite Issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reloader and other classes assume that any mounted Padrino app has "prerequisites" (plural!) set, and uses that to figure out what files need to be reloaded. And, in the documentation, it says to
MyApp.prerequisites << "somefile.rb"if you want to configure your application to reload/require new things.This doesn't seem to break an actual Padrino app, as all the internal Padrino code (besides this) uses the plural. However, when I mount (and therefore wrap) my Grape::API application, reloading breaks, because there is no list of pluralized prerequisites to work with. Boo!