New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erubi Support #2089
Comments
Yes, you are welcome to submit a PR. |
@adam12 do you want to implement the support for this? |
@wikimatze I'm going to explore adding it, yes. |
Perfect, looking forward to your contribution. |
Actually Rails is moving to Erubi also: rails/rails#27757 |
Implemented in #2090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be worth considering support for Erubi, either in addition or in replacement of Erubis. I won't go into the benefits of Erubi - Jeremy Evans does a great job in the README.
I ran some benchmarks using my code here: https://gist.github.com/adam12/8c3613d0c9ba6ebddc8eb8a962b36323
In summary:
(the following tests run with
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]
)Performance Benchmark
Memory Benchmark
Some data removed for brevity
I'd be willing to submit a PR should this be of interest.
The text was updated successfully, but these errors were encountered: