Exceptions in #before block are not caught by error handler

[Wardrop]

I've noticed in Padrino 0.10.5 that exceptions raised from a #before block do not invoke the user-defined error handlers, e.g.

before do
  raise StandardError, "Something went wrong"
end

error do
  "Sorry, but your request could not be fulfilled"
end

I attempted to upgrade to 0.10.6 to see if the problem still exists, however my application completely broke, that's a separate issue though, so I'll have to assume the behavior is unchanged in 0.10.6 unless someone can prove otherwise.

[nesquena]

can you elaborate on 'my app completely broke'. Are you using pry?

[Wardrop]

My configure blocks were being executed before any of dependencies (models, library file) were loaded. 0.10.5 loaded everything before the configure blocks were run, after all the whole point of a configure block is to configure the application environment which includes application dependencies.

Anyway I'm more concerned about the issue with before block errors not being caught. Something else I've noticed is that if a route raises an exception, before blocks are called again. So they're called once at the start of the request, and then called again whenever an error occurs. This may be part of the same issue as this doesn't seem like the intended behavior.

[nesquena]

OK thanks for the report. We will investigate soon.

[ujifgc]

The second part of the issue is related to #818

[ujifgc]

@Wardrop the error do part should be error 500 do in your code to customize StandardError or other common exceptions.