Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minitest fix #1287

Merged
merged 2 commits into from May 14, 2013
Merged

Minitest fix #1287

merged 2 commits into from May 14, 2013

Conversation

Ortuna
Copy link
Member

@Ortuna Ortuna commented May 14, 2013

Minitest upgraded to 5, but unfortunately has breaking changes here

Should keep major version to 4? Don't use minitest much but I think version 4 should be reasonable ?

@nesquena
Copy link
Member

Wow that is a really breaking change. Locking to ~> 4 for now it is. Thanks!

nesquena added a commit that referenced this pull request May 14, 2013
@nesquena nesquena merged commit d146158 into padrino:master May 14, 2013
@Ortuna Ortuna deleted the minitest-fix branch May 14, 2013 22:50
@dariocravero
Copy link

Thanks @Ortuna!! @nesquena I reckon we can look at replacing that? Looks like we're only using it in one place:

@daris.local➜  padrino-framework git:(master) grep "MiniTest::Unit.output" **/*.rb
padrino-core/test/mini_shoulda.rb:MiniTest::Unit.output = ColoredIO.new(MiniTest::Unit.output)

I might be wrong but I think we should be using minitest/pride for that.

Thoughts?

@achiurizo
Copy link
Member

@Ortuna @nesquena @dariocravero 4 is fine for now, but we should move to 5 ASAP. This also likely means the minitest generators need to be updated for minitest 5.

@nesquena
Copy link
Member

minitest is currently locked at ~> 2.6 in our generators so those are OK until we want to move them to 5 also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants