New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minitest fix #1287

Merged
merged 2 commits into from May 14, 2013

Conversation

Projects
None yet
4 participants
@Ortuna
Member

Ortuna commented May 14, 2013

Minitest upgraded to 5, but unfortunately has breaking changes here

Should keep major version to 4? Don't use minitest much but I think version 4 should be reasonable ?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena May 14, 2013

Member

Wow that is a really breaking change. Locking to ~> 4 for now it is. Thanks!

Member

nesquena commented May 14, 2013

Wow that is a really breaking change. Locking to ~> 4 for now it is. Thanks!

nesquena added a commit that referenced this pull request May 14, 2013

@nesquena nesquena merged commit d146158 into padrino:master May 14, 2013

1 check was pending

default The Travis CI build is in progress
Details

@Ortuna Ortuna deleted the Ortuna:minitest-fix branch May 14, 2013

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero May 14, 2013

Contributor

Thanks @Ortuna!! @nesquena I reckon we can look at replacing that? Looks like we're only using it in one place:

@daris.local➜  padrino-framework git:(master) grep "MiniTest::Unit.output" **/*.rb
padrino-core/test/mini_shoulda.rb:MiniTest::Unit.output = ColoredIO.new(MiniTest::Unit.output)

I might be wrong but I think we should be using minitest/pride for that.

Thoughts?

Contributor

dariocravero commented May 14, 2013

Thanks @Ortuna!! @nesquena I reckon we can look at replacing that? Looks like we're only using it in one place:

@daris.local➜  padrino-framework git:(master) grep "MiniTest::Unit.output" **/*.rb
padrino-core/test/mini_shoulda.rb:MiniTest::Unit.output = ColoredIO.new(MiniTest::Unit.output)

I might be wrong but I think we should be using minitest/pride for that.

Thoughts?

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu May 14, 2013

Member

@Ortuna @nesquena @dariocravero 4 is fine for now, but we should move to 5 ASAP. This also likely means the minitest generators need to be updated for minitest 5.

Member

achiu commented May 14, 2013

@Ortuna @nesquena @dariocravero 4 is fine for now, but we should move to 5 ASAP. This also likely means the minitest generators need to be updated for minitest 5.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena May 15, 2013

Member

minitest is currently locked at ~> 2.6 in our generators so those are OK until we want to move them to 5 also.

Member

nesquena commented May 15, 2013

minitest is currently locked at ~> 2.6 in our generators so those are OK until we want to move them to 5 also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment