New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem that Breadcrumb#del does not work when name type is String. #1356

Merged
merged 4 commits into from Jul 20, 2013

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Jul 20, 2013

No description provided.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 20, 2013

Member

A test maybe?

Member

ujifgc commented Jul 20, 2013

A test maybe?

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Jul 20, 2013

Member

Would this be OK?

Member

namusyaka commented Jul 20, 2013

Would this be OK?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jul 20, 2013

Member

Excellent! Thank you!

Member

ujifgc commented Jul 20, 2013

Excellent! Thank you!

ujifgc added a commit that referenced this pull request Jul 20, 2013

Merge pull request #1356 from namusyaka/fix-breadcrumbs
fix a problem that Breadcrumb#del does not work when name type is String, add tests

@ujifgc ujifgc merged commit 3e7ebbe into padrino:master Jul 20, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment