New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padrino::Cache::Helpers::Page Content-Type Issue #745

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@sumskyi
Contributor

sumskyi commented Jan 5, 2012

store both response_buffer and content_type in cache; tests fix

@sumskyi

This comment has been minimized.

Show comment
Hide comment
@sumskyi

sumskyi Jan 10, 2012

Contributor

Why no one of these pull requests was merged?

Contributor

sumskyi commented Jan 10, 2012

Why no one of these pull requests was merged?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jan 10, 2012

Member

This one will be merged soon, thanks

Member

nesquena commented Jan 10, 2012

This one will be merged soon, thanks

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jan 22, 2012

Member

Merged: 8f746e0

Thanks!

Member

DAddYE commented Jan 22, 2012

Merged: 8f746e0

Thanks!

@DAddYE DAddYE closed this Jan 22, 2012

@joslinm

This comment has been minimized.

Show comment
Hide comment
@joslinm

joslinm Jul 22, 2013

Contributor

Why was this commit reverted? See sumskyi@732a31b

I'm setting the content_type beforehand, but unfortunately it's no longer being sent back with the cached version. This breaks a compatibility issue I have with an iOS library (MMRecord) which expects a content-type of 'text/json' or similar.

Contributor

joslinm commented Jul 22, 2013

Why was this commit reverted? See sumskyi@732a31b

I'm setting the content_type beforehand, but unfortunately it's no longer being sent back with the cached version. This breaks a compatibility issue I have with an iOS library (MMRecord) which expects a content-type of 'text/json' or similar.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Jul 23, 2013

Contributor

@joslinm judging by this commit, let's ask @DAddYE why it was changed like that.

Contributor

dariocravero commented Jul 23, 2013

@joslinm judging by this commit, let's ask @DAddYE why it was changed like that.

@tune

This comment has been minimized.

Show comment
Hide comment
@tune

tune Oct 8, 2013

I also have difficulties caused by above revert.
May I know the right way to set content_type in cache, @DAddYE ?

tune commented Oct 8, 2013

I also have difficulties caused by above revert.
May I know the right way to set content_type in cache, @DAddYE ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment