Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve linking error #9

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Conversation

ivg
Copy link
Contributor

@ivg ivg commented Oct 28, 2016

A Ppx_forest module was referenced by both forest_ppx library and
the ppx_forest executable. This created a loop in the dependency
graph, under which the topological sorting is not defined, consequently
this lead to a compilation command with an incorrect ordering of
libraries (forest_ppx came before the forest_parser).

A `Ppx_forest` module was referenced by both `forest_ppx` library and
the `ppx_forest` executable. This created a loop in the dependency
graph, under which the topological sorting is not defined, consequently
this lead to a compilation command with an incorrect ordering of
libraries (`forest_ppx` came before the `forest_parser`).
@ivg
Copy link
Contributor Author

ivg commented Oct 28, 2016

My emacs is set up to remove trailing whitespaces, that's why the fix is so long, in fact it should be one line of code change, i.e., deleting one line. So, if this extra noise bothers you, then I can try to disable this feature, and resubmit. Alternatively, you can just fix it yourself, and close the PR :)

@jonathan-dilorenzo jonathan-dilorenzo merged commit 79abc80 into padsproj:master Oct 30, 2016
@jonathan-dilorenzo
Copy link
Contributor

Awesome! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants