Adding displayName to the Spec #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to specify a display name for the component. This is set automatically by the JSX compiler when using JSX. When the display name is not set, all componenents are displayed as <Unknown>. http://facebook.github.io/react/docs/component-specs.html#displayname
|
Looks good, but how do you actually specify the display name? |
|
Also, could you please exclude |
|
Ah, will do on the exclude for I was thinking to manually create a spec to specify the display name. But I can add a function |
|
I was thinking that something like |
|
Right. I've added the |
|
👍 thanks! |
|
Thank you! On Wednesday, January 28, 2015, Phil Freeman notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to specify a display name for the component. This is set automatically by the JSX compiler when using JSX. When the display name is not set, all components are displayed as
<Unknown>.I realize this is adding an additional property to the Spec record. However, I admit that being able to name the components was quite helpful during app development and debugging. If your intention is to keep the Spec small, I could go either way on this. Or perhaps there is a better or alternative approach? I am open to ideas!