Create an element from a ComponentClass #9
Conversation
An example use-case for this function is when a component class is imported and it is desired to render an instance of this class within another component or as the top-level component. For instance, rackt/react-router exports Route, DefaultRoute, RouteHandler, etc. The createElementFromClass function can be used to render these exported classes.
|
This looks good. However, I put together a similar PR recently. My question is how we should handle props correctly. If I create my own component class, its props are part of its type, but using this new function, I can use it with any props. Can you see a way to resolve this without making all of the props untyped? |
|
Ah, sorry about that. I totally missed pull request #4. Good point about the props. I will take a second look. Hopefully we can find a good way to do this. |
|
I've been thinking about how to resolve this issue, and I admit that I still don't have an approach in mind yet for thermite. However, I have been exploring a free monad based abstraction for react, purescript-reactf, which keeps the type of the props with a component, whether it is created by the user or imported as a foreign import. The |
|
I think it looks really nice :) I need to spend a bit more time to fully understand it, but I like it. |
|
Thanks! And I am definitely open to any suggestions or ideas that you or others might have. |
|
This has been implemented in 0.7.0. |
|
Looks good. Thanks! On Sunday, May 17, 2015, Phil Freeman notifications@github.com wrote:
|
An example use-case for this function is when a component class is imported and it is desired to render an instance of this class within another component or as the top-level component.
For instance, rackt/react-router exports Route, DefaultRoute, RouteHandler, etc. The createElementFromClass function can be used to render these exported classes.
As a note, I am still pretty new at React, so perhaps there is a better way to do this. Or maybe there is already a way to achieve what I want here. I am open to ideas or alternatives.