This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
feature: add dynamodb logging support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hails
force-pushed
the
feature/add-dynamodb-support
branch
2 times, most recently
from
5736365
to
0427d7f
Compare
|
Quando você faz pair com sí mesmo. |
🚀
|
Boa! Docs são importantes! |
macabu
suggested changes
Feb 18, 2019
| awsRegion, ok := os.LookupEnv("DEPLOYER_AWS_REGION") | ||
| if !ok { | ||
| fmt.Printf("DEPLOYER_AWS_REGION must be defined") | ||
| os.Exit(1) |
There was a problem hiding this comment.
Por que somente retornar false ou coisa do tipo, para que esta feature seja opcional? Se eu não tiver interesse ou usar dynamodb não consigo usar o app mais?
There was a problem hiding this comment.
concordaria de primeira, mas pensando na demanda dele com a gente, não podemos dar essa opção por questão de uma pessoal mal intencionada poderia usar essa feature quando quisesse que não fosse logada.
added 5 commits
February 18, 2019 14:47
hails
force-pushed
the
feature/add-dynamodb-support
branch
from
f2f90f3
to
5695782
Compare
claytonsilva
approved these changes
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12