Fix Crashes when Sprites for Pokémon are missing #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where a missing sprite will cause the game to crash instead of using the base sprite or the Substitute sprite. Failsafes were already in place to load these backups, this code just allows a graceful fail and a simple error message instead of a crash.
XGSleepWalker
approved these changes
May 17, 2024
Greenlamp2
reviewed
May 17, 2024
Greenlamp2
approved these changes
May 18, 2024
Madmadness65
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a missing sprite will cause the game to crash instead of using the base sprite or the Substitute sprite.
Failsafes were already in place to load these backups, this code just allows a graceful fail and a simple error message instead of a crash.
Back sprites are missing but regular sprites can be used instead
Error.404.mp4
Sprites are completely missing for a Pokmeon
Missing.Images.mp4