Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Allow learning of new level 0 moves on form change #2718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fontbane
Copy link
Contributor

What are the changes?

  • If a mon changes into a different form with a different level 0 move from its previous form, it will learn that move
  • Main example would be Zacian and Zamazenta learning Behemoth Blade/Bash on form change
  • Also fixed Ash Greninja learning Water Shuriken twice

Why am I doing these changes?

  • QoL and thematic purposes so the moves are learned on form change as intended
  • Save the player a memory mushroom

What did change?

  • Added an extra bit to FormChangePhase to compare the form's moveset to the previous one and trigger a LearnMovePhase if a new move is found at level 0

Screenshots/Videos

How to test the changes?

  • Move FORM_CHANGE_ITEM to Common tier and set its weight really high
  • Start a run with Zacian, take a Rusted Sword, you will be prompted to learn Behemoth Blade

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@flx-sta flx-sta added Enhancement New feature or request Game Design / Balance For things that heavily impact the game labels Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Game Design / Balance For things that heavily impact the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants