Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qol] Add an option to import settings #2729

Open
wants to merge 13 commits into
base: beta
Choose a base branch
from

Conversation

prateau
Copy link
Contributor

@prateau prateau commented Jun 30, 2024

What are the changes?

Added an option in the manage data menu to import and export settings

Why am I doing these changes?

I oftenly clear the cookies of my browser and so I often have to re-enter all my settings manually. This is not fun.

Maybe this could be extended in the future to key mapping settings

What did change?

I added two entries in the manage data menu to import and export the settings.

As I'm native in french but not in the other languages, I only added translation for english and french. Let me know if I need to translate the menu entries in the other language (with google translate)

Screenshots/Videos

Enregistrement.de.l.ecran.2024-06-30.220931.mp4

How to test the changes?

This can be tested by exporting and importing settings with the new option menu.

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@flx-sta flx-sta added Enhancement New feature or request Miscellaneous Changes that don't fit under any other label labels Jul 1, 2024
@prateau prateau requested a review from Adri1 July 1, 2024 21:04
prateau and others added 2 commits July 1, 2024 23:12
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Copy link
Contributor

@Arxxer Arxxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES localization done

src/locales/es/menu-ui-handler.ts Outdated Show resolved Hide resolved
Co-authored-by: Arxxer <javiptn7@gmail.com>
@prateau prateau requested a review from Arxxer July 1, 2024 21:35
src/locales/zh_CN/menu-ui-handler.ts Outdated Show resolved Hide resolved
src/locales/zh_TW/menu-ui-handler.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good morning
i added Korean localization!

src/locales/ko/menu-ui-handler.ts Outdated Show resolved Hide resolved
prateau and others added 3 commits July 2, 2024 10:05
Co-authored-by: RimKnight <rimknight852@gmail.com>
Co-authored-by: RimKnight <rimknight852@gmail.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@NicusPulcis
Copy link
Contributor

hey @prateau i've added italian

@prateau
Copy link
Contributor Author

prateau commented Jul 7, 2024

Fixed conflicts

@prateau
Copy link
Contributor Author

prateau commented Jul 7, 2024

hey @prateau i've added italian

Hey I'm sorry but I don't see your change anywhere

@f-fsantos f-fsantos changed the base branch from main to beta July 10, 2024 17:46
@NicusPulcis
Copy link
Contributor

@prateau if you wanna add them yourself there they are:

"Import Settings" -> "Importa impostazioni"
"Export Settings" -> "Esporta impostazioni"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants