Python3 fixes for ping and zlib #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ping request fails under Python 3 due to incorrect byte/string handling. Test by sending a HTTP request to locally running frontend and backend with Python 2 and 3. Also connect to pagekite.net service with Python 2 and 3.
Byte/string conversion has not be done for zlib compression. Test by sending a HTTP request to locally running frontend and backend with Python 2 and 3. Also connect to pagekite.net service with Python 2 and 3.
|
Just a reminder, Pagekite is not functional with pagekite.net without this patch. |
gucci-on-fleek
added a commit
to gucci-on-fleek/IoT-Gateway-for-Docker
that referenced
this pull request
Feb 26, 2020
Pagekite is broken until pagekite/PyPagekite#75 is merged, so we will use the proposed PR until then. More superfluous files have been removed to decrease the image size, and (hopefully) all of the sqlite warning spam has been disabled.
|
Thank you for doing this! I'll try and get this tested and tagged today. |
|
A release tag with this fix would be nice to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a frontend for local test cases, the Debian autopkgtest suite for Pagekite was failing. Investigation led to the following fixes.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950249
Please tag a new release after this fix. Thanks.