Remove support for SSLv3, make SSLv23 the default #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSLv3 is broken: https://en.wikipedia.org/wiki/POODLE PROTOCOL_SSLv23 is recommended for maximum compatibility with all versions of SSL/TLS. Python's inbuilt ssl library has itself switched to SSLv3 in future versions. https://bugs.python.org/issue20896 https://hg.python.org/cpython/rev/55f62fa5bebc Debian has removed the PROTOCOL_SSLv3 constant from its patched version of Python standard libraries. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768611 Other libraries adopting similar appoach: https://github.com/gevent/gevent/pull/517/files
|
Thank you for doing this. This got fixed in 32fcd4e I believe, sorry I never merged your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLv3 is broken: https://en.wikipedia.org/wiki/POODLE
PROTOCOL_SSLv23 is recommended for maximum compatibility with all
versions of SSL/TLS.
Python's inbuilt ssl library has itself switched to SSLv3 in future
versions.
https://bugs.python.org/issue20896
https://hg.python.org/cpython/rev/55f62fa5bebc
Debian has removed the PROTOCOL_SSLv3 constant from its patched version
of Python standard libraries.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768611
Other libraries adopting similar appoach:
https://github.com/gevent/gevent/pull/517/files