Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links to ids missing the target #7

Closed
Andy-ABTec opened this issue Dec 24, 2017 · 3 comments
Closed

External links to ids missing the target #7

Andy-ABTec opened this issue Dec 24, 2017 · 3 comments

Comments

@Andy-ABTec
Copy link

Just discovered this...

If I open https://pages-themes.github.io/leap-day/ in a browser and click on the "header 2" link on the left hand side everything works as it should, and the page scrolls to a position to show "header 2" just below the banner.

However, if I copy the "header 2" link (https://pages-themes.github.io/leap-day/#header-2) and paste it into a new browser window or tab "header 2" ends up behind the banner somewhere and you have to scroll up to see it.

Happy Christmas!

Andy B.

@stale
Copy link

stale bot commented Feb 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 24, 2018
@lambdacasserole
Copy link
Contributor

Proposed fix in PR #19.

@stale stale bot removed the wontfix label Feb 26, 2018
@stale
Copy link

stale bot commented Apr 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 27, 2018
@stale stale bot closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants