Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dark theme support with @media queries #121

Open
wants to merge 108 commits into
base: master
Choose a base branch
from

Conversation

godalming123
Copy link

@godalming123 godalming123 commented Aug 18, 2021

This branch works however a few elements still need deferent colors for dark mode.

elements to add colors for:

  • .downloads ul a:active
  • a load of colors for code blocks

elements that I have added colors for:

  • body color when you are printing
  • small element
  • blockquete
  • dt
  • small inside a
  • kbd background
  • kbd border
  • kbd border-bottom-color
  • kbd boxshadow
  • kbd color
  • a hovered
  • pre color, border
  • th
  • a element
  • ul.downloads background
  • ul.downloads border
  • .downloads li border-right
  • .downlads a
  • .downloads focus+hover
  • th, td border-bottom

I have used @media (prefers-color-scheme){ } queries to make this possible https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme. if you would like to see what I have done please check out https://godalming123.github.io/minimal/ the dark theme applies if your device is in dark mode and your browser supports @media prefers color scheme.

@welcome
Copy link

welcome bot commented Aug 18, 2021

Welcome! Congrats on your first pull request to the Minimal theme. If you haven't already, please be sure to check out the contributing guidelines.

@godalming123
Copy link
Author

just added support for changing the theme with a config.yaml option that deafualts to auto in master brach!

_layouts/default.html Outdated Show resolved Hide resolved
Copy link

@ElManouche ElManouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

README.md Outdated Show resolved Hide resolved
_config.yml Outdated Show resolved Hide resolved
_layouts/default.html Outdated Show resolved Hide resolved
@ldemailly
Copy link

It'd be great to see this merged but in meantime, what do I put in my _config.yml to use this branch/fork?

@davorpa
Copy link

davorpa commented Nov 30, 2021

It'd be great to see this merged but in meantime, what do I put in my _config.yml to use this branch/fork?

See how to remote-theme gem works. can be pointed to any repo+branch

https://github.com/benbalter/jekyll-remote-theme

godalming123 and others added 3 commits December 21, 2021 13:03
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@godalming123
Copy link
Author

It'd be great to see this merged but in meantime, what do I put in my _config.yml to use this branch/fork?

Sorry for not looking at the comments for a while to use this theme follow the instructions at https://github.com/godalming123/minimal#usage and then deploy your site with github pages

godalming123 and others added 2 commits December 21, 2021 13:14
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@davorpa
Copy link

davorpa commented Dec 23, 2021

@godalming123, to be merged as feature in github-pages you should revert changes made in theme name:

I highly recommend using feature branches workflow instead coding all in master/main 🤗

In any way.... great work!!!!

@godalming123
Copy link
Author

@godalming123, to be merged as feature in github-pages you should revert changes made in theme name:

I highly recommend using feature branches workflow instead coding all in master/main hugs

In any way.... great work!!!!

I'm probably not going to add this until maintainers see the pull request as my current goal would be to attract as many new users and that means documenting how to set this up so they can use it. And I dont even know if this repo is still maintained.

@godalming123
Copy link
Author

Want a more maintained fork?

If you would like a better maintained fork (as I rarely see posts here and am no longer updating this pull request as I see it as complete) see: https://github.com/BDHU/minimalist

@davorpa
Copy link

davorpa commented Dec 25, 2021

and that means documenting how to set this up so they can use it. And I dont even know if this repo is still maintained.

@parkr, as ex-github... do you know if pages-themes project is carried on maintained?

@godalming123 godalming123 changed the title add dark theme support with @media querys add dark theme support with @media quiries May 7, 2023
@godalming123 godalming123 changed the title add dark theme support with @media quiries add dark theme support with @media queries May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants