Skip to content

Commit

Permalink
fixing up color contrast issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@mgifford
mgifford committed Apr 21, 2017
1 parent 5143e88 commit ef69e5a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
7 changes: 5 additions & 2 deletions _sass/jekyll-theme-slate.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ footer p {

a {
text-decoration: none;
color: #007edf;
color: #0F79D0;
text-shadow: none;

transition: color 0.5s ease;
Expand All @@ -113,7 +113,10 @@ a {
-ms-transition: text-shadow 0.5s ease;
}

a:hover, a:focus {text-decoration: underline;}
a:hover, a:focus {
text-decoration: underline;
font-weight:bold;

This comment has been minimized.

Sign in to view

Copy link
@lhmouse

lhmouse Mar 6, 2018

Contributor

Why was this added? When the mouse cursor moves over a hyperlink now it gets embolded, pushing everything after the link backwards.

This comment has been minimized.

Sign in to view

Copy link
@mgifford

mgifford Mar 6, 2018

Author Contributor

Interesting.. Not sure how that would happen. The html here just changes the color & makes it bold. Those other elements must be related to something else.

This comment has been minimized.

Sign in to view

Copy link
@lhmouse

lhmouse Mar 6, 2018

Contributor

@mgifford In my browser (Opera 51.0.2830.40, the User-Agent says Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.168 Safari/537.36 OPR/51.0.2830.40) bold text is rendered horizontally longer than normal text thus takes up more space, which causes the glitch.

This comment has been minimized.

Sign in to view

Copy link
@mgifford

mgifford Mar 6, 2018

Author Contributor

Ok, then nix the + font-weight:bold;

I'm fine with that.
}

footer a {
color: #F2F2F2;
Expand Down
14 changes: 7 additions & 7 deletions _sass/rouge-github.scss
View file
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
.highlight table td { padding: 5px; }
.highlight table pre { margin: 0; }
.highlight .cm {
color: #999988;
color: #777772;
font-style: italic;
}
.highlight .cp {
color: #999999;
color: #797676;
font-weight: bold;
}
.highlight .c1 {
color: #999988;
color: #777772;
font-style: italic;
}
.highlight .cs {
color: #999999;
color: #797676;
font-weight: bold;
font-style: italic;
}
.highlight .c, .highlight .cd {
color: #999988;
color: #777772;
font-style: italic;
}
.highlight .err {
Expand All @@ -37,7 +37,7 @@
color: #aa0000;
}
.highlight .gh {
color: #999999;
color: #797676;
}
.highlight .gi {
color: #000000;
Expand Down Expand Up @@ -144,7 +144,7 @@
color: #008080;
}
.highlight .bp {
color: #999999;
color: #797676;
}
.highlight .nb {
color: #0086B3;
Expand Down

0 comments on commit ef69e5a

Please sign in to comment.