Toast-Component-New #178
Merged
Toast-Component-New #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 12, 2019
vinodloha
reviewed
Dec 13, 2019
vinodloha
reviewed
Dec 13, 2019
vinodloha
reviewed
Dec 13, 2019
vinodloha
reviewed
Dec 13, 2019
| {showToast && ( | ||
| <div className={`${className} ${variation}`}> | ||
| <Button className="toast-close" onClick={() => close()}> | ||
| <img src="/images/close.svg" width="12px" alt="close button" /> |
There was a problem hiding this comment.
Replace this with Icon component
There was a problem hiding this comment.
Created a New Issue Task in reference to #190
vinodloha
reviewed
Dec 13, 2019
vinodloha
reviewed
Dec 13, 2019
| .toast-text img { | ||
| padding-right: 0.8em; | ||
| } | ||
| .toast-close { |
There was a problem hiding this comment.
To be updated along with ICON
There was a problem hiding this comment.
Created a New Issue Task in reference to #190
There was a problem hiding this comment.
Can you also move your SVG icons lib/static/images to styles/themes/base/icons?
vinodloha
reviewed
Dec 13, 2019
vinodloha
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.