Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

webp transcoding does not work for MapProxyDomain resources written in-place. #1149

Closed
jmarantz opened this issue Oct 6, 2015 · 1 comment
Closed

webp transcoding does not work for MapProxyDomain resources written in-place. #1149

jmarantz opened this issue Oct 6, 2015 · 1 comment
Assignees
@jmarantz

Comments

@jmarantz
Copy link
Contributor

jmarantz commented Oct 6, 2015

If you have
MapProxyDomain mps_host/origin origin_host/static
a request for:
http://mps_host/origin/foo.jpg
will not be transcoded to webp.

This might seem like an odd case, because why would a browser request http://mps_host/origin/foo.jpg? It works fine with MapProxyDomain when there is URL rewriting in HTML, in which case the webp request is encoded in the rewritten URL and it is not rewritten in-place.

However you can in theory construct an HTML page with MapProxyDomain and a bunch of references to external images via their manually rewritten proxied location, say, as a demo showing the benefits of passing those images through MPS.
@jmarantz jmarantz self-assigned this Oct 6, 2015
jmarantz added a commit that referenced this issue Oct 9, 2015
@jmarantz
Allow IPRO transcoding to work with MapProxyDomain, addressing
52f0d46 
#1149

Note that IPRO+MPD was working (and optimizing) in MPS; it just wasn't
getting the right UA/Accept-header bits propagated into the
request_properties, so webp transcoding didn't happen.
@jeffkaufman
Copy link
Contributor

Fixed by 52f0d46

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmarantz jmarantz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffkaufman @jmarantz