-
Notifications
You must be signed in to change notification settings - Fork 158
Auto-updating broken with new deb systems #1428
Comments
We may be able to fix this by modifying the existing packages without a full rebuild, since it's a packaging issue and not a code issue. |
This is now fixed on I've modified our existing packages in-place to make three changes:
Next step is to spin up VMs to test these, which I'm planning to do tomorrow morning. If that goes well I'll plan to sign the packages, and push them out first thing monday morning. |
In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. Patch from https://chromium.googlesource.com/chromium/src.git/+/389af6af989c5ba5384988b55fc28a3f231a1479%5E%21/#F0 Fixes #1428
In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was concatenating that variable into a path, assuming the trailing slash. But in Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file, and the cronjob fails to fix it. Patch from https://chromium.googlesource.com/chromium/src.git/+/389af6af989c5ba5384988b55fc28a3f231a1479%5E%21/#F0 Fixes #1428
Modifying the package in place means the version we compiled-in is wrong. I'm going to stop messing with this and just build packages the right way, building a debian-only patch release 1.11.33.5 |
I've built the first round of packages (64-bit debs) and am testing them. I've set up four VMs:
On the upgrade ones I'm going to first install 1.11.33.4 and then 1.11.33.5, while on the plain ones I'll just install 1.11.33.5. |
Installing 1.11.33.4 on 16.04 and 16.10, I see So: bug reproduced. |
After installing 1.11.33.5 on all four VMs, all four show So: bug confirmed fixed by 1.11.33.5 |
(For future reference, I'm seeing |
Packages are built and signed. Planning to push them out monday morning to avoid releasing on a friday afternoon. |
1.11.33.5 is released and announced; closing this. |
Ubuntu 16.10 and the forthcoming Debian 9 have a change that breaks our auto-updating. Chrome ran into the same bug https://bugs.chromium.org/p/chromium/issues/detail?id=663069 and has a patch: https://chromium.googlesource.com/chromium/src.git/+/389af6af989c5ba5384988b55fc28a3f231a1479%5E%21/#F0
This is more serious for Chrome than mod_pagespeed because Debian 9 is still unstable, and people usually don't use non-LTS Ubuntu for servers, but it's still pretty urgent. We probably need to put out a patch release for this.
The text was updated successfully, but these errors were encountered: