Release 1.5.27.3

[jeffkaufman]

Bugfix release. Release notes to come.

[patschi]

The pagespeed header is still "1.5.27.2-2912" - shouldn't it be also updated to "1.5.27.3"? Thanks for your awesome work :)

[jeffkaufman]

Sorry, release 1.5.27.3 isn't out yet. This is a bug to track the release as I work on it.

[jeffkaufman]

(But all the fixes listed above except #313 are already in the latest master.)

[ghost]

Jeff, can you look at my issue #361 ? Thanks
I think it would be better to provide a normal tarball source for psol that compiles like any other source we are used to. Every single nginx module I used compiles directly into nginx without any issues, all those compiling deps are a showstopper for users adopting pagespeed.

[kongkongchu]

Just tried 1.5.27.3 on CentOS 5.9 x86, it works now. Thank you Jeff.

./configure --add-module=$HOME/ngx_pagespeed-release-1.5.27.3-beta

[kongkongchu]

"make" doesn't work still with 1.5.27.3 on CentOS 5.9 x86. gcc version 4.1.2 20080704 (Red Hat 4.1.2-54)

    -lpthread -lcrypt -lstdc++ /root/ngx_pagespeed-release-1.5.27.3-beta/psol/lib/Release/linux/ia32/pagespeed_automatic.a /root/ngx_pagespeed-release-1.5.27.3-beta/psol/lib/Release/linux/ia32/libserf.a /root/ngx_pagespeed-release-1.5.27.3-beta/psol/lib/Release/linux/ia32/libaprutil.a /root/ngx_pagespeed-release-1.5.27.3-beta/psol/lib/Release/linux/ia32/libapr.a -lrt -pthread -lm -lpcre /root/openssl/openssl-1.0.1e/.openssl/lib/libssl.a /root/openssl/openssl-1.0.1e/.openssl/lib/libcrypto.a -ldl -lz -lGeoIP

/root/ngx_pagespeed-release-1.5.27.3-beta/psol/lib/Release/linux/ia32/pagespeed_automatic.a(101.system.o.o): In function cv::tempfile(char const*)': system.cpp:(.text._ZN2cv8tempfileEPKc+0x1e): warning: the use oftmpnam' is dangerous, better use mkstemp' objs/addon/src/ngx_base_fetch.o: In functionnet_instaweb::NgxBaseFetch::DecrefAndDeleteIfUnreferenced()':
/root/ngx_pagespeed-release-1.5.27.3-beta/src/ngx_base_fetch.cc:197: undefined reference to __sync_add_and_fetch_4' collect2: ld returned 1 exit status make[1]: *** [objs/nginx] Error 1 make[1]: Leaving directory/root/nginx-1.4.1'
make: *** [build] Error 2

[jeffkaufman]

undefined reference to __sync_add_and_fetch_4

I reproduced this in a VM, and was able to fix this by adding to ./configure:

--with-cc-opt='-DLINUX=2 -D_REENTRANT -D_LARGEFILE64_SOURCE -march=i686 -pthread'

So this would be something like:

./configure --add-module=$HOME/ngx_pagespeed --with-cc-opt='-DLINUX=2 -D_REENTRANT -D_LARGEFILE64_SOURCE -march=i686 -pthread'

Does this work for you?

[jeffkaufman]

Actually, I think the only important part of that ./configure line is the -march=i686. So you should just be able to do:

./configure --add-module=$HOME/ngx_pagespeed --with-cc-opt='-march=i686'

[kongkongchu]

It works with,

--with-cc-opt='-DLINUX=2 -D_REENTRANT -D_LARGEFILE64_SOURCE -march=i686 -pthread'

Will try the other later.

--with-cc-opt='-march=i686'

Thanks

From: Jeff Kaufman [mailto:notifications@github.com]
Sent: Thursday, May 16, 2013 5:30 PM
To: pagespeed/ngx_pagespeed
Cc: kongkongchu
Subject: Re: [ngx_pagespeed] Release 1.5.27.3 (#366)

Actually, I think the only important part of that ./configure line is the -march=i686. So you should just be able to do:

./configure --add-module=$HOME/ngx_pagespeed --with-cc-opt='-march=i686'

—
Reply to this email directly or view it on GitHub #366 (comment) . https://github.com/notifications/beacon/P3dMLj-IuYvTk5BKd-FLC6nn0JBsy6NN_54JtXnQwFWQDeg2V_S9rfF2ErkoPQXX.gif

[ghost]

1.5.27.3 compiles perfectly with provided psol binaries, in both CentOS 5.9 and 6.4 64bits. Many thanks Jeff!

[kongkongchu]

--with-cc-opt='-march=i686' works, thank you Jeff. Only CentOS 5.9 x86 need --with-cc-opt='-march=i686', CentOS 5.9 x64 doesn't need it.

./configure --add-module=$HOME/ngx_

pagespeed-release-1.5.27.3-beta
--with-cc-opt='-march=i686'

[jeffkaufman]

Released in 1.5.27.3