Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme.md to link to underlying packages docs on iam permissions #37

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update readme.md to link to underlying packages docs on iam permissions #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d91ec6e
Update readme.md
throttlehead-dev Jan 5, 2023
bbd680e
Add create_group config option, pass through to underlying logger
throttlehead-dev Jan 6, 2023
0e905e0
Update readme with new opt
throttlehead-dev Jan 6, 2023
79a7799
Merge pull request #1 from throttlehead-dev/dev/add-create-group-opt
throttlehead-dev Jan 6, 2023
d601eeb
Merge pull request #2 from pagevamp/master
throttlehead-dev Sep 21, 2023
06dac95
Made create_group optional
throttlehead-dev Sep 21, 2023
75a8bb7
Merge pull request #3 from throttlehead-dev/dev/add-create-group-opt
throttlehead-dev Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ Config for logging is defined at `config/logging.php`. Add `cloudwatch` to the `
'group_name' => env('CLOUDWATCH_LOG_GROUP_NAME', 'laravel_app'),
'version' => env('CLOUDWATCH_LOG_VERSION', 'latest'),
'formatter' => \Monolog\Formatter\JsonFormatter::class,
'batch_size' => env('CLOUDWATCH_LOG_BATCH_SIZE', 10000),
'batch_size' => env('CLOUDWATCH_LOG_BATCH_SIZE', 10000),
'create_group' => env('CLOUDWATCH_CREATE_GROUP', true)
'via' => \Pagevamp\Logger::class,
],
]
Expand All @@ -51,6 +52,10 @@ And set the `LOG_CHANNEL` in your environment variable to `cloudwatch`.

If the role of your AWS EC2 instance has access to Cloudwatch logs, `CLOUDWATCH_LOG_KEY` and `CLOUDWATCH_LOG_SECRET` need not be defined in your `.env` file.

### AWS IAM permissions

The needed permissions can be found [here](https://github.com/maxbanton/cwh#aws-iam-needed-permissions).

### Contribution

I have added a `pre-commit` hook to run `php-cs-fixer` whenever you make a commit. To enable this run `sh hooks.sh`.
Expand Down
4 changes: 3 additions & 1 deletion src/Logger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Pagevamp;

use Monolog\Logger as MonoLogger;
use Aws\CloudWatchLogs\CloudWatchLogsClient;
use PhpNexus\Cwh\Handler\CloudWatch;
use Monolog\Formatter\LineFormatter;
Expand Down Expand Up @@ -29,9 +30,10 @@ public function __invoke(array $config)
$streamName = $loggingConfig['stream_name'];
$retentionDays = $loggingConfig['retention'];
$groupName = $loggingConfig['group_name'];
$createGroup = isset($loggingConfig['create_group']) ? $loggingConfig['create_group'] : true;
$batchSize = isset($loggingConfig['batch_size']) ? $loggingConfig['batch_size'] : 10000;

$logHandler = new CloudWatch($cwClient, $groupName, $streamName, $retentionDays, $batchSize);
$logHandler = new CloudWatch($cwClient, $groupName, $streamName, $retentionDays, $batchSize, [], MonoLogger::DEBUG, true, $createGroup);
$logger = new \Monolog\Logger($loggingConfig['name']);

$formatter = $this->resolveFormatter($loggingConfig);
Expand Down