Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web_app_deploy workflow #47

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

lucacavallaro
Copy link
Member

@lucacavallaro lucacavallaro commented Jun 17, 2024

List of changes

  1. Add web_app_deploy.yaml workflow

Changes from function_app_deploy.yaml

  1. This workflow builds the artifact using esbuild and zip instead of npm-pack-zip and bundledDependencies
  2. The artifacts created by this workflow contains a "plain old javascript project" with index.js, package.json and node_modules
  3. This workflow can create artifacts for all kind of workspaces (function apps, app services) as long they have an entrypoint specified in the main field of their package.json file

Motivation and context

This workflow is required to use Yarn Plug'n'Play in production workflow and to unify the artifact building for node projects.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Other information

@lucacavallaro lucacavallaro requested a review from a team as a code owner June 17, 2024 09:28
.github/workflows/web_app_deploy.yaml Outdated Show resolved Hide resolved
.github/workflows/web_app_deploy.yaml Outdated Show resolved Hide resolved
@lucacavallaro lucacavallaro force-pushed the add-web-app-deploy-workflow branch 24 times, most recently from 2842c82 to 4aaa0ff Compare June 21, 2024 13:21
@lucacavallaro lucacavallaro force-pushed the add-web-app-deploy-workflow branch 14 times, most recently from 2822c2e to c4166b2 Compare June 21, 2024 16:09
.github/workflows/web_app_deploy.yaml Show resolved Hide resolved
.github/workflows/web_app_deploy.yaml Outdated Show resolved Hide resolved
.github/workflows/web_app_deploy.yaml Outdated Show resolved Hide resolved
@lucacavallaro lucacavallaro requested a review from a team as a code owner July 17, 2024 08:30
@gunzip gunzip self-requested a review July 26, 2024 10:24
@lucacavallaro lucacavallaro merged commit 0a7835b into main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants