[chore] Add optional switchTestID to ListItemSwitch
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vangaorth
changed the title
switchTestID to ListItemSwitch
dmnplb
approved these changes
May 3, 2024
Vangaorth
added a commit
to pagopa/io-app
that referenced
this pull request
May 23, 2024
…een, new DS (#5734)⚠️ This PR depends on #5732⚠️ ⚠️ This PR depends on [io-app-design-system#253](pagopa/io-app-design-system#253)⚠️ ⚠️ This PR depends on [io-app-design-system#256](pagopa/io-app-design-system#256)⚠️ ## Short description This PR aligns the Push Notifications Opt In screen and the profile push notification settings to the new DS |Both on<br/>upper part|Both on<br/>scrolled down|Bottom sheet| |-|-|-| |||| |Preview Off<br/>Reminder On|Preview On<br/>Reminder Off|Both Off| |-|-|-| |||| |Profile<br/>Both on|Profile<br/>Bottom sheet| |-|-| ||| |Profile<br/>On Off|Profile<br/>Off On|Profile<br/>Off Off| |-|-|-| |||| ## List of changes proposed in this pull request - All related onboarding screens have been ported to the new DS - A lot of test snapshot have been updated due to a change in margins on the DS library ## How to test Using the io-dev-api-server, configure the profile in order to have both `reminder_status` and `push_notifications_content_type` set to undefined. Perform a login and the opt-in screen should appear. Check that both values are properly set after tapping the "Continue" button. For the profile screen, navigate to it and change switches' values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR add the
switchTestIDtoListItemSwitchin order for tests to directly retrieve the switch valueList of changes proposed in this pull request
switchTestIDproperty onListItemSwitchthat is later assigned astestIDto the internalNativeSwitchcomponent