Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOBP-564] Update payment's validation/verification failures #368

Merged

Conversation

mastro993
Copy link
Contributor

Short description

This PR updates the payment's validation/verification failures, which can be configured via config.json file

List of changes proposed in this pull request

  • Updated API definitions
  • Updated WalletPaymentFailure type

How to test

Tests should pass correclty

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mastro993 mastro993 merged commit b881405 into master Apr 18, 2024
6 checks passed
mastro993 added a commit to pagopa/io-app that referenced this pull request Apr 18, 2024
> [!WARNING]
> This PR depends on
pagopa/io-dev-api-server#368

## Short description
This PR updates the pagoPA API definitions to update the payment's
verification/validation failures mappings

## List of changes proposed in this pull request
- Updated pagoPA API definitions
- Updated `WalletPaymentFailure` type
- Added missing mappings in payment's failure screen

## How to test
Checkout [this PR](pagopa/io-dev-api-server#368)
on the `io-dev-api-server`.
Add the following piece of configuration in the` config.json` file and
play around with fault category codes, trying to reproduce the error
screens.

```json
 "features": {
    "wallet": {
      "verificationFailure": {
        "faultCodeCategory": "PAYMENT_UNKNOWN",
        "faultCodeDetail": "PAA_PAGAMENTO_SCONOSCIUTO"
      }
    }
  }
  ```

## Preview

https://github.com/pagopa/io-app/assets/6160324/7efaee4f-cb79-46ba-99a6-f62d25fa40fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants