Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#ENTE-20] Update @pagopa/io-functions-commons fix authorized cidrs #108

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

BurnedMarshal
Copy link
Contributor

List of Changes

  • upgrade io-functions-commons to @pagopa/io-functions-commons

Motivation and Context

The new version of @pagopa/io-functions-commons fix failure when a Service has an authorized CIDR without a subnet.

How Has This Been Tested?

  • unit test

Types of changes

  • Chore
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Mar 30, 2021

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

New dependencies added: @pagopa/io-functions-commons.

@pagopa/io-functions-commons

Author: https://www.pagopa.gov.it

Description: Common code for Azure functions

Homepage: https://github.com/pagopa/io-functions-commons#readme

Created3 months ago
Last Updated7 days ago
LicenseMIT
Maintainers5
Releases6
Direct Dependencies@azure/cosmos, @pagopa/ts-commons, applicationinsights, azure-storage, cidr-matcher, fp-ts, helmet, helmet-csp, io-functions-express, io-ts, node-fetch, nodemailer, nodemailer-sendgrid, referrer-policy, rehype-stringify, remark-frontmatter, remark-parse, remark-rehype, request-ip, ulid, unified and winston
README

io-functions-commons

Common code across Azure functions of project IO.

To release a new package on GitHub and npm:

yarn release-it <minor|major|patch>

Upgrading from 13.x to 14.x

Version 14.x is the first version that uses italia-utils 5.x,
a major upgrade to the package that generates the provided Typescript definitions.

This translates in the fact that you must upgrade italia-utils to a version >= 5.x
if you want to upgrade your deps using io-functions-common 14.x.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #108 (19fe110) into master (cad0523) will decrease coverage by 0.03%.
The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   81.82%   81.79%   -0.04%     
==========================================
  Files          27       27              
  Lines         886      890       +4     
  Branches       89       90       +1     
==========================================
+ Hits          725      728       +3     
- Misses        160      161       +1     
  Partials        1        1              
Impacted Files Coverage Δ
GetLimitedProfileByPOST/handler.ts 83.33% <ø> (ø)
WebhookNotificationActivity/client.ts 100.00% <ø> (ø)
utils/comma-separated-list.ts 90.00% <90.00%> (ø)
CreateMessage/handler.ts 63.46% <100.00%> (ø)
CreateService/handler.ts 87.50% <100.00%> (ø)
EmailNotificationActivity/handler.ts 71.42% <100.00%> (ø)
EmailNotificationActivity/utils.ts 63.15% <100.00%> (ø)
GetLimitedProfile/handler.ts 83.87% <100.00%> (ø)
GetMessage/handler.ts 87.27% <100.00%> (ø)
GetService/handler.ts 84.37% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9c252...19fe110. Read the comment docs.

Copy link
Contributor

@balanza balanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BurnedMarshal BurnedMarshal force-pushed the ENTE-20-fix-authorized-cidrs-subnet branch from 2e7beaa to 19fe110 Compare April 6, 2021 14:40
@BurnedMarshal BurnedMarshal merged commit 3d6b1ce into master Apr 7, 2021
@BurnedMarshal BurnedMarshal deleted the ENTE-20-fix-authorized-cidrs-subnet branch April 7, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants