Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-298] Remove legal messages #278

Merged
merged 15 commits into from
Sep 21, 2023
Merged

[#IOCOM-298] Remove legal messages #278

merged 15 commits into from
Sep 21, 2023

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Aug 28, 2023 •
edited
Loading

List of Changes

Motivation and Context

We want to remove legal messages cause they are unused

This PR depends on pagopa/io-functions-commons#335.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-298

@Garma00
Copy link
Contributor Author

Garma00 commented Sep 13, 2023

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dpulls
Copy link

dpulls bot commented Sep 15, 2023

🎉 All dependencies have been resolved !

@Garma00 Garma00 marked this pull request as ready for review September 15, 2023 15:57
@Garma00 Garma00 requested a review from a team as a code owner September 15, 2023 15:57
michaeldisaro
michaeldisaro requested changes Sep 18, 2023
View reviewed changes
GetMessage/__tests__/handler.test.ts Outdated Show resolved Hide resolved
GetMessage/handler.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

michaeldisaro
michaeldisaro approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this should be safe to deploy. We are removing, hopefully, unused endpoints. I don't think the are services still calling this unsopported feature's endpoint.

@Garma00 Garma00 merged commit 0f96775 into master Sep 21, 2023
5 checks passed
@Garma00 Garma00 deleted the IOCOM-298-remove-legal-messages branch September 21, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@pagopa-github-bot pagopa-github-bot Awaiting requested review from pagopa-github-bot pagopa-github-bot is a code owner automatically assigned from pagopa/io-backend-contributors

@drmarro drmarro Awaiting requested review from drmarro drmarro is a code owner automatically assigned from pagopa/io-backend-contributors

@acuiuli acuiuli Awaiting requested review from acuiuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Garma00 @michaeldisaro