Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-538] Add "..." at the end of the message content when it's truncated #280

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[#IOCOM-538] Add "..." at the end of the message content when it's truncated #280

merged 2 commits into from
Sep 18, 2023

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Sep 18, 2023

List of Changes

Add "..." at the end of the message content when it's truncated

Motivation and Context

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00 Garma00 requested a review from a team as a code owner September 18, 2023 08:24
@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-538

@Garma00 Garma00 changed the title Add "..." at the end of the message content when it's truncated [#IOCOM-538] Add "..." at the end of the message content when it's truncated Sep 18, 2023
acuiuli
acuiuli approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michaeldisaro
michaeldisaro requested changes Sep 18, 2023
View reviewed changes
EmailNotification/utils.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Garma00 Garma00 merged commit aa9677b into master Sep 18, 2023
5 checks passed
@Garma00 Garma00 deleted the IOCOM-538-fix-template-mail branch September 18, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@acuiuli acuiuli acuiuli approved these changes

@rodoviti rodoviti Awaiting requested review from rodoviti rodoviti is a code owner automatically assigned from pagopa/io-backend-contributors

@gquadrati gquadrati Awaiting requested review from gquadrati gquadrati is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Garma00 @michaeldisaro @acuiuli