Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPAE-592] Remove Old Services Deprecated APIs #283

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[#IOPAE-592] Remove Old Services Deprecated APIs #283

merged 1 commit into from
Oct 2, 2023

Conversation

giamma1295
Copy link
Contributor

We are removing the Old Services APIs that has been replaced with the new one provided by io-services-cms

List of Changes

  • Remove /services api reference from openapi.yaml
  • Remove /services/{service_id} api reference from openapi.yaml
  • Remove /services/{service_id}/logo api reference from openapi.yaml
  • Remove /services/{service_id}/keys api reference from openapi.yaml

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giamma1295 giamma1295 requested a review from a team as a code owner October 2, 2023 08:29
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-592

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@giamma1295 giamma1295 merged commit c19828f into master Oct 2, 2023
5 checks passed
@giamma1295 giamma1295 deleted the IOPAE-592-service-api-deprecated-remove branch October 2, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppedipinto giuseppedipinto giuseppedipinto approved these changes

@gunzip gunzip Awaiting requested review from gunzip gunzip is a code owner automatically assigned from pagopa/io-backend-contributors

@drmarro drmarro Awaiting requested review from drmarro drmarro is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giamma1295 @giuseppedipinto