Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-920] new io-functions-commons version for configuration_id field in CreateMessage #296

Merged
merged 2 commits into from
Jan 24, 2024
Merged

[#IOCOM-920] new io-functions-commons version for configuration_id field in CreateMessage #296

merged 2 commits into from
Jan 24, 2024

Conversation

acuiuli
Copy link
Contributor

@acuiuli acuiuli commented Jan 22, 2024 •
edited
Loading

List of Changes

Motivation and Context

Updated the io-functions-commons version in order to add the new optional configuration_id field in the CreateMessage API

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@acuiuli acuiuli requested a review from a team as a code owner January 22, 2024 10:05
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-920

@acuiuli acuiuli changed the title [#IOCOM-920] new io-functions-commons version for configuration_id fiel in CreateMessage [#IOCOM-920] new io-functions-commons version for configuration_id field in CreateMessage Jan 22, 2024
michaeldisaro
michaeldisaro reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the test to check that everything works with or without the new property?

michaeldisaro
michaeldisaro requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add tests

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@acuiuli acuiuli merged commit c37d1f4 into master Jan 24, 2024
4 checks passed
@acuiuli acuiuli deleted the IOCOM-920-CREATE-MESSAGE-CONFIGURATION-ID branch January 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@Garma00 Garma00 Garma00 approved these changes

@giuseppedipinto giuseppedipinto Awaiting requested review from giuseppedipinto giuseppedipinto is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acuiuli @michaeldisaro @Garma00