[#IOCOM-987] Invalidate clickable links in email #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace links with "[link rimosso]"
add a zero-width space in order to make links not clickable
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOCOM-987 |
michaeldisaro
requested changes
Jan 26, 2024
If we add a zero-width space for every `.` before the text is truncated then the truncated text could contain less than 134 visible character.
|
michaeldisaro
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
The text where we are using the regex will always been of 134 character so we are not affected by the problem highlighted by sonar.
Motivation and Context
We want to avoid clickable links in email
How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: