Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCOM-1005] Fixed openapi with endpoint placed security #298

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Moved security header to every path because.

Motivation and Context

Codegen does not allow the override for just CMS endpoints, so we have to move security headers to every endpoint.

How Has This Been Tested?

yarn build
codegen client
tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@michaeldisaro michaeldisaro requested a review from a team as a code owner January 29, 2024 14:00
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1005

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Garma00 Garma00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaeldisaro michaeldisaro merged commit c2949ac into master Jan 29, 2024
4 checks passed
@michaeldisaro michaeldisaro deleted the fixed-openapi-security branch January 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants