hotfix authNrequest ID format

pagopa · Jan 5, 2023 · 630ad26 · 630ad26
1 parent e052c2e
commit 630ad26
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/strategy/__tests__/saml_client.test.ts b/src/strategy/__tests__/saml_client.test.ts
@@ -394,7 +394,7 @@ describe("CustomSamlClient#generateAuthorizeRequest", () => {
     );
     const jwkThumbprint = await jose.calculateJwkThumbprint(aJwkPubKey);
     const lollipopSamlRequest = samlRequestWithID(
-      `${DEFAULT_LOLLIPOP_HASH_ALGORITHM}:${jwkThumbprint}`
+      `${DEFAULT_LOLLIPOP_HASH_ALGORITHM}-${jwkThumbprint}`
     );
     mockWrapCallback.mockImplementation(callback => {
       callback(null, samlRequest);
@@ -443,7 +443,7 @@ describe("CustomSamlClient#generateAuthorizeRequest", () => {
       setTimeout(() => {
         expect(mockSet).toBeCalled();
         expect(mockCallback).toBeCalledWith(null, expectedSamlRequest);
-        expect(`${DEFAULT_LOLLIPOP_HASH_ALGORITHM}:${jwkThumbprint}`).toEqual(
+        expect(`${DEFAULT_LOLLIPOP_HASH_ALGORITHM}-${jwkThumbprint}`).toEqual(
           expectedSamlRequestXML["samlp:AuthnRequest"].$.ID
         );
         resolve(undefined);

diff --git a/src/utils/__tests__/samlUtils.test.ts b/src/utils/__tests__/samlUtils.test.ts
@@ -87,7 +87,7 @@ describe("getAuthorizeRequestTamperer", () => {
         DEFAULT_LOLLIPOP_HASH_ALGORITHM
       );
       expect(authnRequest.$.ID).toEqual(
-        `${DEFAULT_LOLLIPOP_HASH_ALGORITHM}:${thumbprint}`
+        `${DEFAULT_LOLLIPOP_HASH_ALGORITHM}-${thumbprint}`
       );
       expect(
         authnRequest["samlp:NameIDPolicy"][0].$.AllowCreate

diff --git a/src/utils/samlUtils.ts b/src/utils/samlUtils.ts
@@ -733,7 +733,7 @@ export const getAuthorizeRequestTamperer = (
                 ),
                 TE.map(
                   ({ hashingAlgo, jwkThumbprint }) =>
-                    `${hashingAlgo}:${jwkThumbprint}`
+                    `${hashingAlgo}-${jwkThumbprint}`
                 ),
                 TE.chain(requestId =>
                   TE.tryCatch(async () => {